Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 974183005: Cache locally function templates returned by gin::CreateFunctionTemplate (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache locally function templates returned by gin::CreateFunctionTemplate V8 caches FunctionTemplates for a lifetime of a web page for its own internal reasons, thus it is generally a good idea to cache the template returned by gin::CreateFunctionTemplate function. Otherwise, repeated method invocations from JS will create substantial memory leaks. BUG=463487 Committed: https://crrev.com/48a180623e4e2b4d3dc32d19281d617603218000 Cr-Commit-Position: refs/heads/master@{#321330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M content/renderer/pepper/message_channel.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 3 chunks +20 lines, -6 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mnaganov (inactive)
5 years, 9 months ago (2015-03-04 17:27:19 UTC) #2
mnaganov (inactive)
raymes@: Ping!
5 years, 9 months ago (2015-03-06 09:50:51 UTC) #3
raymes
lgtm
5 years, 9 months ago (2015-03-18 23:19:09 UTC) #4
raymes
On 2015/03/18 23:19:09, raymes wrote: > lgtm and again, I'm really sorry for the long ...
5 years, 9 months ago (2015-03-18 23:21:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974183005/1
5 years, 9 months ago (2015-03-19 08:47:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 10:36:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:37:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a180623e4e2b4d3dc32d19281d617603218000
Cr-Commit-Position: refs/heads/master@{#321330}

Powered by Google App Engine
This is Rietveld 408576698