Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 974143002: Throw if webview has been destroyed (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw if webview has been destroyed New APIs can be more strict about enforcing not being called after destroy. BUG=457184 Committed: https://crrev.com/b2b11fdea2692c93392b48cbfacce749efc99cf2 Cr-Commit-Position: refs/heads/master@{#319093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
boliu
ptal
5 years, 9 months ago (2015-03-04 01:03:39 UTC) #2
Tobias Sargeant
lgtm
5 years, 9 months ago (2015-03-04 16:21:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974143002/1
5 years, 9 months ago (2015-03-04 17:20:54 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-04 17:20:55 UTC) #7
boliu
+hush for committer stamp
5 years, 9 months ago (2015-03-04 17:22:03 UTC) #9
hush (inactive)
lgtm
5 years, 9 months ago (2015-03-04 18:40:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974143002/1
5 years, 9 months ago (2015-03-04 18:41:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 19:03:36 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:04:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2b11fdea2692c93392b48cbfacce749efc99cf2
Cr-Commit-Position: refs/heads/master@{#319093}

Powered by Google App Engine
This is Rietveld 408576698