Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 974133002: [cast] Stub out call to VideoEncoderImpl::IsSupported on iOS. (Closed)

Created:
5 years, 9 months ago by jfroy
Modified:
5 years, 9 months ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cast] Stub out call to VideoEncoderImpl::IsSupported on iOS. CL 906403006 introduced a linking error by referencing a symbol that is not included in iOS builds of the cast sender library. This patch stubs out the relevant code. BUG=463713 Committed: https://crrev.com/cc24128062d1f6b34052460bf4b3f7f854b263b4 Cr-Commit-Position: refs/heads/master@{#318996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/cast/sender/video_encoder.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jfroy
5 years, 9 months ago (2015-03-04 00:39:06 UTC) #2
miu
lgtm
5 years, 9 months ago (2015-03-04 00:54:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974133002/1
5 years, 9 months ago (2015-03-04 00:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 02:03:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:04:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc24128062d1f6b34052460bf4b3f7f854b263b4
Cr-Commit-Position: refs/heads/master@{#318996}

Powered by Google App Engine
This is Rietveld 408576698