Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 974083002: cc: Remove scheduler power monitoring. (Closed)

Created:
5 years, 9 months ago by sunnyps
Modified:
5 years, 9 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove scheduler power monitoring. Power monitoring was added to the scheduler based on the incorrect assumption that it would allow the system to use a lower timer resolution on windows. This is not true because the timer resolution is always high when on AC power while DelayBasedTimeSource is used for vsync timing. On battery power the high resolution timer is disabled by the power monitor irrespective of the presence of high resolution timer tasks. BUG=448939 Committed: https://crrev.com/969a20562c23ef36b21462202db2b526c60e3f9f Cr-Commit-Position: refs/heads/master@{#319000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -218 lines) Patch
M cc/scheduler/scheduler.h View 6 chunks +1 line, -14 lines 0 comments Download
M cc/scheduler/scheduler.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 7 chunks +4 lines, -156 lines 0 comments Download
M cc/test/scheduler_test_common.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sunnyps
I've asked cpu@ to confirm what the CL description says. I'll post an update here ...
5 years, 9 months ago (2015-03-03 23:27:23 UTC) #2
sunnyps
PTAL. cpu@ confirmed that: 1. While a page is loading we use a timer to ...
5 years, 9 months ago (2015-03-03 23:59:45 UTC) #3
brianderson
lgtm
5 years, 9 months ago (2015-03-04 01:18:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/974083002/1
5 years, 9 months ago (2015-03-04 01:21:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 02:15:49 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:16:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/969a20562c23ef36b21462202db2b526c60e3f9f
Cr-Commit-Position: refs/heads/master@{#319000}

Powered by Google App Engine
This is Rietveld 408576698