Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: runtime/vm/parser.h

Issue 974073002: Fix async machinery for finally clauses (issues 22445, 22300). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
===================================================================
--- runtime/vm/parser.h (revision 44206)
+++ runtime/vm/parser.h (working copy)
@@ -592,12 +592,21 @@
void AddCatchParamsToScope(CatchParamDesc* exception_param,
CatchParamDesc* stack_trace_param,
LocalScope* scope);
- void SaveExceptionAndStacktrace(LocalVariable* exception_var,
+ void SetupExceptionVariables(LocalScope* try_scope,
+ bool is_async,
+ LocalVariable** context_var,
+ LocalVariable** exception_var,
+ LocalVariable** stack_trace_var,
+ LocalVariable** saved_exception_var,
+ LocalVariable** saved_stack_trace_var);
+ void SaveExceptionAndStacktrace(SequenceNode* statements,
+ LocalVariable* exception_var,
LocalVariable* stack_trace_var,
LocalVariable* saved_exception_var,
LocalVariable* saved_stack_trace_var);
// Parse all the catch clause of a try.
SequenceNode* ParseCatchClauses(intptr_t handler_pos,
+ bool is_async,
LocalVariable* exception_var,
LocalVariable* stack_trace_var,
LocalVariable* rethrow_exception_var,
@@ -605,7 +614,11 @@
const GrowableObjectArray& handler_types,
bool* needs_stack_trace);
// Parse finally block and create an AST for it.
- SequenceNode* ParseFinallyBlock();
+ SequenceNode* ParseFinallyBlock(bool is_async,
+ LocalVariable* exception_var,
+ LocalVariable* stack_trace_var,
+ LocalVariable* rethrow_exception_var,
+ LocalVariable* rethrow_stack_trace_var);
// Adds try block to the list of try blocks seen so far.
void PushTryBlock(Block* try_block);
// Pops the inner most try block from the list.
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698