Text blob run paints should be filtered.

Text blob run paints should be filtered.

We're constructing blob run paints after the canvas draw filter has been
applied.

Instead, we need do defer text blob draw filters until we have access
to the full run paints.

BUG=skia:3494
R=reed@google.com,mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/024f996c1daac32ecad1f9ffec15f0e54fb207f4

[f(malita), 2015-03-03 21:23:45]

https://codereview.chromium.org/973973003/diff/1/include/core/SkDraw.h
File include/core/SkDraw.h (right):

https://codereview.chromium.org/973973003/diff/1/include/core/SkDraw.h#newcod...
include/core/SkDraw.h:152: SkDrawFilter*   fDrawFilter;    // optional
I guess this could also be passed explicitly to SkBaseDevice::drawTextBlob()
instead.

[reed1, 2015-03-03 21:26:22]

lgtm w/ nits

Definitely want some gm/tests eventually.

https://codereview.chromium.org/973973003/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/973973003/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:240: fDrawFilter = fCanvas->getDrawFilter();
nit: cavas-> instead of fCanvas, just to match the lines above (and no blank
line)?

https://codereview.chromium.org/973973003/diff/1/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/973973003/diff/1/src/core/SkDevice.cpp#newcod...
src/core/SkDevice.cpp:139: if (!!draw.fDrawFilter) {
style: its fine to say

if (draw.fDrawFilter), no need for !!

[f(malita), 2015-03-03 22:02:17]

Thanks, will do. I'll also add a GM to cover this.

In the meantime, I've uploaded a different approach (PS#2) - less intrusive, if
somewhat more hacky. Let me know which one you prefer.

[reed1, 2015-03-03 22:13:15]

I like #2 
lgtm

[f(malita), 2015-03-04 03:02:11]

On 2015/03/03 22:13:15, reed1 wrote:
> I like #2 
> lgtm

I have a GM ready, but there are some draw filter complications - I'll upload
separately to discuss.

[f(malita), 2015-03-04 03:04:11]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-03-04 03:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/973973003/#ps40001 (title:
"fix iterator filter skipping")

[commit-bot: I haz the power, 2015-03-04 03:05:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973973003/40001

[commit-bot: I haz the power, 2015-03-04 03:08:21]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/024f996c1daac32ecad1f9ffec15f0e54fb207f4