Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 973893002: [telemetry] Add public module counter. (Closed)

Created:
5 years, 9 months ago by dtu
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add public module counter. BUG=461551 TEST=None. R=eakuefner Committed: https://crrev.com/c52617fee2c9268d7ee3ce7d0cc90e4c80618483 Cr-Commit-Position: refs/heads/master@{#318991}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A tools/telemetry/count View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eakuefner
+aiolos because i haven't gone for committer yet. lgtm nit: trailing whitespace i think we ...
5 years, 9 months ago (2015-03-03 23:58:17 UTC) #2
eakuefner
https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count File tools/telemetry/count (right): https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count#newcode36 tools/telemetry/count:36: for module in modules: On 2015/03/03 23:58:17, eakuefner wrote: ...
5 years, 9 months ago (2015-03-04 00:00:47 UTC) #3
dtu
https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count File tools/telemetry/count (right): https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count#newcode36 tools/telemetry/count:36: for module in modules: On 2015/03/04 00:00:47, eakuefner wrote: ...
5 years, 9 months ago (2015-03-04 00:01:27 UTC) #4
aiolos (Not reviewing)
On 2015/03/04 00:00:47, eakuefner wrote: > https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count > File tools/telemetry/count (right): > > https://codereview.chromium.org/973893002/diff/1/tools/telemetry/count#newcode36 > ...
5 years, 9 months ago (2015-03-04 00:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973893002/20001
5 years, 9 months ago (2015-03-04 00:03:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 01:26:09 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 01:26:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c52617fee2c9268d7ee3ce7d0cc90e4c80618483
Cr-Commit-Position: refs/heads/master@{#318991}

Powered by Google App Engine
This is Rietveld 408576698