Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 973873003: WebUI generator GN build file fixed. (Closed)

Created:
5 years, 9 months ago by dzhioev (left Google)
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI generator GN build file fixed. In case when GN output dir is inside src/, GN uses pathes relative to src/ directory that start with // (//out/Release/gen). But python interprets such pathes as relative to /. BUG=459230 Committed: https://crrev.com/240be55564f8d82c1e8281e052f15f6258185068 Cr-Commit-Position: refs/heads/master@{#319058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/webui_generator/generator/wug.gni View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
5 years, 9 months ago (2015-03-03 19:39:30 UTC) #2
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-04 12:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973873003/1
5 years, 9 months ago (2015-03-04 12:52:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 13:16:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:16:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/240be55564f8d82c1e8281e052f15f6258185068
Cr-Commit-Position: refs/heads/master@{#319058}

Powered by Google App Engine
This is Rietveld 408576698