Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 973873002: Remove deprecated URL attribute alias from EventSource interface (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 9 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, arv+blink, vivekg_samsung, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-events_chromium.org, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/eventsource/script-tests/eventsource-url-attribute.js View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/eventsource/workers/eventsource-url-attribute-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/EventSource.idl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
Looks good. Since no one else said followed up my inclusion of this in the ...
5 years, 9 months ago (2015-03-04 04:08:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973873002/20001
5 years, 9 months ago (2015-03-05 00:57:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-05 00:57:12 UTC) #5
jsbell
Whoops, needs an actual l-g-t-m here :) philipj@ - r? cq?
5 years, 9 months ago (2015-03-05 00:57:54 UTC) #6
philipj_slow
lgtm
5 years, 9 months ago (2015-03-05 04:06:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973873002/20001
5 years, 9 months ago (2015-03-05 04:07:04 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 06:06:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191340

Powered by Google App Engine
This is Rietveld 408576698