Split command holding object (GrTargetCommands) out of GrInOrderDrawBuffer

Split command holding object (GrTargetCommands) out of GrInOrderDrawBuffer

This is still a bit odd in that the IoDB and TargetCommands are annoyingly interwoven. This should improve a bit when batching is everywhere.

Joshua - I think you're lead on this.

Committed: https://skia.googlesource.com/skia/+/dad7794dcbf205a6d0f3c5c44e251897f5256f09

[robertphillips, 2015-03-03 15:50:30]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org

[joshualitt, 2015-03-03 16:43:19]

On 2015/03/03 15:52:08, robertphillips wrote:

Is targetcommands getting its own header / cpp file at some point?

[robertphillips, 2015-03-03 16:44:31]

On 2015/03/03 16:43:19, joshualitt wrote:
> On 2015/03/03 15:52:08, robertphillips wrote:
> 
> Is targetcommands getting its own header / cpp file at some point?

Right - this patch will be followed by a mechanical one that breaks the new
class into its own header and .cpp. I left them together so reviewers could more
clearly see what was going where.

[joshualitt, 2015-03-03 16:46:46]

On 2015/03/03 16:44:31, robertphillips wrote:
> On 2015/03/03 16:43:19, joshualitt wrote:
> > On 2015/03/03 15:52:08, robertphillips wrote:
> > 
> > Is targetcommands getting its own header / cpp file at some point?
> 
> Right - this patch will be followed by a mechanical one that breaks the new
> class into its own header and .cpp. I left them together so reviewers could
more
> clearly see what was going where.

lgtm

[robertphillips, 2015-03-03 16:59:09]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-03-03 17:00:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973853002/20001

[robertphillips, 2015-03-03 17:03:30]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-03-03 17:07:18]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-03-03 17:07:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/973853002/#ps40001 (title:
"Address compilation complaint")

[commit-bot: I haz the power, 2015-03-03 17:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973853002/40001

[commit-bot: I haz the power, 2015-03-03 17:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 17:08:55]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[robertphillips, 2015-03-03 17:13:08]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-03-03 17:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/973853002/#ps60001 (title:
"Address compilation complaint")

[commit-bot: I haz the power, 2015-03-03 17:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973853002/60001

[commit-bot: I haz the power, 2015-03-03 17:28:20]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/dad7794dcbf205a6d0f3c5c44e251897f5256f09