pydir/run-pnacl-sz.py - Issue 973823003: Subzero: Run sandboxed cross tests, and do some cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/run-pnacl-sz.py

Issue 973823003: Subzero: Run sandboxed cross tests, and do some cleanup. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix TODO. Fix accidentally reverted required change. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/run-pnacl-sz.py

diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py

index 65eb22bf70c10436f9b2b7eba409240c6354ee48..97f4361cfb35a37077e3affb9ee272b07dd87463 100755

--- a/pydir/run-pnacl-sz.py

+++ b/pydir/run-pnacl-sz.py

@@ -112,7 +112,10 @@ def main():

asm_temp.close()

if args.assemble and args.filetype != 'obj':

cmd += ['|', os.path.join(llvm_bin_path, 'llvm-mc'),

- '-triple=i686-none-nacl',

+ # TODO(stichnot): -triple=i686-nacl should be used for a

+ # sandboxing test. This means there should be an args.sandbox

+ # argument that also gets passed through to pnacl-sz.

+ '-triple=i686',

'-filetype=obj', '-o', asm_temp.name]

elif asm_temp:

cmd += ['-o', asm_temp.name]

« no previous file with comments | « pydir/crosstest.py ('k') | runtime/szrt.c » ('j') | no next file with comments »