Subzero: Run sandboxed cross tests, and do some cleanup.

src/IceIntrinsics.h

 //===- subzero/src/IceIntrinsics.h - List of Ice Intrinsics -----*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares the kinds of intrinsics supported by PNaCl.
@@ skipping 127 matching lines @@
     // Returns number of arguments expected.
     SizeT getNumArgs() const {
       assert(NumTypes > 1);
       return NumTypes - 1;
     }
 
     // Returns type of Index-th argument.
     Type getArgType(SizeT Index) const;
   };
 
-  // Find the information about a given intrinsic, based on function name.
-  // The function name is expected to have the common "llvm." prefix
-  // stripped. If found, returns a reference to a FullIntrinsicInfo entry
-  // (valid for the lifetime of the map). Otherwise returns null.
-  const FullIntrinsicInfo *find(const IceString &Name) const;
+  // Find the information about a given intrinsic, based on function name.  If
+  // the function name does not have the common "llvm." prefix, nullptr is
+  // returned and Error is set to false.  Otherwise, tries to find a reference
+  // to a FullIntrinsicInfo entry (valid for the lifetime of the map).  If
+  // found, sets Error to false and returns the reference.  If not found, sets
+  // Error to true and returns nullptr (indicating an unknown "llvm.foo"
+  // intrinsic).
+  const FullIntrinsicInfo *find(const IceString &Name, bool &Error) const;
 
 private:
   // TODO(jvoung): May want to switch to something like LLVM's StringMap.
   typedef std::map<IceString, FullIntrinsicInfo> IntrinsicMap;
   IntrinsicMap Map;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEINTRINSICS_H