Test observer removal&destruct during destroy notification.

Test observer removal&destruct during destroy notification.

Add unit test verifying that removal of observers during
LifecycleNotifier<T>::notifyContextDestroyed() is handled as expected.

R=haraken
BUG=462949
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191186

[sof, 2015-03-03 09:31:36]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org

[sof, 2015-03-03 09:31:37]

please take a look.

[haraken, 2015-03-03 10:43:35]

LGTM

https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleCon...
File Source/platform/LifecycleContextTest.cpp (right):

https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleCon...
Source/platform/LifecycleContextTest.cpp:141: TEST(LifecycleContextTest,
observerRemovedDuringNotifyDestroyed)

Shall we add a FIXME and mention that this test should be removed once we make
Oilpan the default and use weak processing for the m_observers?

[sof, 2015-03-03 11:06:05]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-03-03 11:06:06]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/973773002/#ps20001 (title:
"add fixme for future ref.")

[commit-bot: I haz the power, 2015-03-03 11:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973773002/20001

[sof, 2015-03-03 11:12:56]

https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleCon...
File Source/platform/LifecycleContextTest.cpp (right):

https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleCon...
Source/platform/LifecycleContextTest.cpp:141: TEST(LifecycleContextTest,
observerRemovedDuringNotifyDestroyed)
On 2015/03/03 10:43:35, haraken wrote:
> 
> Shall we add a FIXME and mention that this test should be removed once we make
> Oilpan the default and use weak processing for the m_observers?

Yes, useful reminder to have. Done.

[commit-bot: I haz the power, 2015-03-03 12:20:30]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191186