Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 973773002: Test observer removal&destruct during destroy notification. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Test observer removal&destruct during destroy notification. Add unit test verifying that removal of observers during LifecycleNotifier<T>::notifyContextDestroyed() is handled as expected. R=haraken BUG=462949 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191186

Patch Set 1 #

Total comments: 2

Patch Set 2 : add fixme for future ref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -15 lines) Patch
M Source/platform/LifecycleContextTest.cpp View 1 2 chunks +66 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-03 09:31:37 UTC) #2
haraken
LGTM https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleContextTest.cpp File Source/platform/LifecycleContextTest.cpp (right): https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleContextTest.cpp#newcode141 Source/platform/LifecycleContextTest.cpp:141: TEST(LifecycleContextTest, observerRemovedDuringNotifyDestroyed) Shall we add a FIXME and ...
5 years, 9 months ago (2015-03-03 10:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973773002/20001
5 years, 9 months ago (2015-03-03 11:06:34 UTC) #6
sof
https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleContextTest.cpp File Source/platform/LifecycleContextTest.cpp (right): https://codereview.chromium.org/973773002/diff/1/Source/platform/LifecycleContextTest.cpp#newcode141 Source/platform/LifecycleContextTest.cpp:141: TEST(LifecycleContextTest, observerRemovedDuringNotifyDestroyed) On 2015/03/03 10:43:35, haraken wrote: > > ...
5 years, 9 months ago (2015-03-03 11:12:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 12:20:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191186

Powered by Google App Engine
This is Rietveld 408576698