Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 973753002: Remove Width and Height of The Video Content (Closed)

Created:
5 years, 9 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, extensions-reviews_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Width and Height of The Video Content The width and height in CastRtpPayloadParams is deprecated. Removed them. BUG=464607 Committed: https://crrev.com/36574c07d51d0b8775df538e8f2b7e84b8a2de32 Cr-Commit-Position: refs/heads/master@{#320054}

Patch Set 1 #

Patch Set 2 : review fixes #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/end_to_end_sender.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/performance.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (12 generated)
zhuoyu.qian
5 years, 9 months ago (2015-03-03 05:34:42 UTC) #1
Nico
+miu (author of the TODO) to review
5 years, 9 months ago (2015-03-03 05:45:53 UTC) #3
miu
For completeness, please remove the width/height from the IDL file as well: chrome/common/extensions/api/cast_streaming_rtp_stream.idl
5 years, 9 months ago (2015-03-04 02:09:29 UTC) #4
zhuoyu.qian
On 2015/03/04 02:09:29, miu wrote: > For completeness, please remove the width/height from the IDL ...
5 years, 9 months ago (2015-03-04 02:19:40 UTC) #5
miu
lgtm. You'll need to get an lgtm from an owner in chrome/common/extensions/OWNERS for the .idl ...
5 years, 9 months ago (2015-03-04 02:23:22 UTC) #7
zhuoyu.qian
Hi xhwang: I'd like you to take a look at chrome/renderer/media/cast_rtp_stream.cc chrome/renderer/media/cast_rtp_stream.h Hi finnur: I'd ...
5 years, 9 months ago (2015-03-04 02:51:35 UTC) #9
xhwang
You need a per-file owner for cast-*: see: src/chrome/renderer/media/OWNERS s/xhwang/hclam
5 years, 9 months ago (2015-03-04 18:03:44 UTC) #11
Finnur
LGTM, one nit. https://codereview.chromium.org/973753002/diff/20001/chrome/common/extensions/api/cast_streaming_rtp_stream.idl File chrome/common/extensions/api/cast_streaming_rtp_stream.idl (right): https://codereview.chromium.org/973753002/diff/20001/chrome/common/extensions/api/cast_streaming_rtp_stream.idl#newcode1 chrome/common/extensions/api/cast_streaming_rtp_stream.idl:1: // Copyright 2013 The Chromium Authors. ...
5 years, 9 months ago (2015-03-05 10:32:04 UTC) #12
zhuoyu.qian
On 2015/03/05 10:32:04, Finnur wrote: > LGTM, one nit. > > https://codereview.chromium.org/973753002/diff/20001/chrome/common/extensions/api/cast_streaming_rtp_stream.idl > File chrome/common/extensions/api/cast_streaming_rtp_stream.idl ...
5 years, 9 months ago (2015-03-06 01:21:47 UTC) #13
zhuoyu.qian
Hi Alpha: I'd like you to take a look at chrome/renderer/media/cast_rtp_stream.cc chrome/renderer/media/cast_rtp_stream.h
5 years, 9 months ago (2015-03-06 01:22:48 UTC) #14
Alpha Left Google
lgtm
5 years, 9 months ago (2015-03-10 00:28:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973753002/20001
5 years, 9 months ago (2015-03-10 00:29:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/34254)
5 years, 9 months ago (2015-03-10 05:00:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973753002/20001
5 years, 9 months ago (2015-03-11 01:48:27 UTC) #21
zhuoyu.qian
Hi Jay Civelli, I'd like you to take a look at: chrome/test/data/extensions/api_test/cast_streaming/end_to_end_sender.js chrome/test/data/extensions/api_test/cast_streaming/performance.js
5 years, 9 months ago (2015-03-11 05:37:10 UTC) #24
miu
lgtm Test JS changes lgtm.
5 years, 9 months ago (2015-03-11 06:06:03 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973753002/40001
5 years, 9 months ago (2015-03-11 06:06:09 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-11 07:00:51 UTC) #30
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 07:01:23 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/36574c07d51d0b8775df538e8f2b7e84b8a2de32
Cr-Commit-Position: refs/heads/master@{#320054}

Powered by Google App Engine
This is Rietveld 408576698