Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 973723002: Merge: Allow offsets in blobs larger than 2GB on 32 bit Chromium builds. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merge: Allow offsets in blobs larger than 2GB on 32 bit Chromium builds. The recent patch crrev.com/895933007 introduced a regression by using size_t for offsets, which on 32bit builds is sizeof(size_t) = 4 which was causing broken offset values due to assigning a uint64_t variable to such variables. This CL fixes that by simply converting the types to uint64_t. TBR=michaeln@chromium.org # For merge. TEST=*FileSystemProvider*BigFile* on a 32 bit build Chromium build with chromeos=1. BUG=375297, 458122 Review URL: https://codereview.chromium.org/959113002 Cr-Commit-Position: refs/heads/master@{#318808} (cherry picked from commit f6629637feb3bbf186de75da8fe4028a5244389f) Committed: https://chromium.googlesource.com/chromium/src/+/35feed79c8c72b9ab539f7750a35d4c6001c01b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -25 lines) Patch
M content/browser/fileapi/blob_storage_context_unittest.cc View 13 chunks +55 lines, -18 lines 0 comments Download
M storage/browser/blob/blob_storage_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mtomasz
5 years, 9 months ago (2015-03-03 01:45:41 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35feed79c8c72b9ab539f7750a35d4c6001c01b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698