Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 973703002: Buildbucket-based build triggering API (Closed)

Created:
5 years, 9 months ago by nodir
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Buildbucket-based build triggering API If "bucket" is passed to api.trigger, a build is scheduled on buildbucket Depends on https://codereview.chromium.org/968053003/ R=stip@chromium.org BUG=449218 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M scripts/common/annotator.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/step/config.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/trigger/api.py View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nodir
PTAL, small change
5 years, 9 months ago (2015-03-03 01:20:43 UTC) #1
nodir
+smut, since she reviewed api.trigger before https://chromiumcodereview.appspot.com/968053003/ got lgtmed
5 years, 9 months ago (2015-03-04 23:53:39 UTC) #3
ghost stip (do not use)
lgtm
5 years, 9 months ago (2015-03-04 23:55:43 UTC) #4
nodir
On 2015/03/04 at 23:55:43, stip wrote: > lgtm Thanks
5 years, 9 months ago (2015-03-04 23:57:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973703002/1
5 years, 9 months ago (2015-03-04 23:58:20 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 00:02:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294334

Powered by Google App Engine
This is Rietveld 408576698