Check whether a pdf has XFA fields before loading XFA fields

fpdfsdk/src/fpdfview.cpp

Index: fpdfsdk/src/fpdfview.cpp
diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp
index 6a8f8901151245d22673a241466f122f7710ea84..3c5e775165d3f1cffc7a0b1938af16282cb4a623 100644
--- a/fpdfsdk/src/fpdfview.cpp
+++ b/fpdfsdk/src/fpdfview.cpp
@@ -303,43 +303,36 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadDocument(FPDF_STRING file_path, FPDF_BY
 	return pDocument;
 }
 
-DLLEXPORT FX_BOOL STDCALL FPDF_HasXFAField(FPDF_DOCUMENT document, int& docType)
-{
-	if (!document)
-		return FALSE;
-
-	CPDF_Dictionary* pRoot = ((CPDF_Document*)document)->GetRoot();
-	if (!pRoot)
-		return FALSE;
-
-	CPDF_Dictionary* pAcroForm = pRoot->GetDict("AcroForm");
-	if (!pAcroForm)
-		return FALSE;
-
-	CPDF_Object* pXFA = pAcroForm->GetElement("XFA");
-	if (!pXFA)
-		return FALSE;
-
-	FX_BOOL bDynamicXFA = pRoot->GetBoolean("NeedsRendering", FALSE);
-
-	if (bDynamicXFA)
-		docType = DOCTYPE_DYNIMIC_XFA;
-	else
-		docType = DOCTYPE_STATIC_XFA;
-
-	return TRUE;
-}
-
-DLLEXPORT  FPDF_BOOL STDCALL FPDF_LoadXFA(FPDF_DOCUMENT document)
+DLLEXPORT FX_BOOL STDCALL FPDF_HasXFAField(FPDF_DOCUMENT document, int& docType)
 {
-	if (!document) 
+	if (!document || !((CPDFXFA_Document*)document)->GetPDFDoc())

[Tom Sepez, 2015/03/03 00:53:34]

nit: I'd do this as a local variable assignment followed by a separate
if-statemnt just to be consistent with the flow below.  Can we use a C++-style
cast here?

[jun_fang, 2015/03/03 01:02:31]

OK.

+		return FALSE;
+
+	CPDF_Dictionary* pRoot = (((CPDFXFA_Document*)document)->GetPDFDoc())->GetRoot();
+	if (!pRoot)
+		return FALSE;
+
+	CPDF_Dictionary* pAcroForm = pRoot->GetDict("AcroForm");
+	if (!pAcroForm)
 		return FALSE;
 
-	int iDocType = DOCTYPE_PDF;
-	FX_BOOL hasXFAField = FPDF_HasXFAField(document, iDocType);
-	if (!hasXFAField)
+	CPDF_Object* pXFA = pAcroForm->GetElement("XFA");
+	if (!pXFA)
 		return FALSE;
-	return ((CPDFXFA_Document*)document)->LoadXFADoc();
+
+	FX_BOOL bDynamicXFA = pRoot->GetBoolean("NeedsRendering", FALSE);
+
+	if (bDynamicXFA)
+		docType = DOCTYPE_DYNIMIC_XFA;
+	else
+		docType = DOCTYPE_STATIC_XFA;
+
+	return TRUE;
+}
+
+DLLEXPORT  FPDF_BOOL STDCALL FPDF_LoadXFA(FPDF_DOCUMENT document)
+{
+	return (document && ((CPDFXFA_Document*)document)->LoadXFADoc());

[Tom Sepez, 2015/03/03 00:53:34]

nit: outer ( ) not needed.

[jun_fang, 2015/03/03 01:02:30]

OK.

 }