Issue 973613004: Clean up some Dart idioms in fn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973613004: Clean up some Dart idioms in fn (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Clean up some Dart idioms in fn This CL adds license blocks and cleans up a number of Dart idioms in fn. Specifically, I've marked several fields as |final| and used Map#putIfAbsent in some appropriate places. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ea8ee0edad91064a926197d4e08cbfb30c1f1ad6

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -34 lines)			Patch
M	sky/examples/fn/lib/component.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/examples/fn/lib/fn.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/examples/fn/lib/node.dart	View	9 chunks	+15 lines, -11 lines	0 comments	Download
M	sky/examples/fn/lib/reflect.dart	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	sky/examples/fn/lib/style.dart	View	2 chunks	+10 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-04 16:27:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea8ee0edad91064a926197d4e08cbfb30c1f1ad6 (presubmit successful).