Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 973553004: Don't guarantee any particular color order for SkPMFloat. Hide fColor. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't guarantee any particular color order for SkPMFloat. Hide fColor. Also add a little note that get() may incidentally clamp. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7ab42771859145884e1b28c8c45f0a5a728b22ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/core/SkPMFloat.h View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-02 21:51:40 UTC) #2
reed1
5 years, 9 months ago (2015-03-02 21:58:04 UTC) #3
reed1
lgtm
5 years, 9 months ago (2015-03-02 21:58:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973553004/1
5 years, 9 months ago (2015-03-02 22:01:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 22:07:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ab42771859145884e1b28c8c45f0a5a728b22ac

Powered by Google App Engine
This is Rietveld 408576698