Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 973503002: Remove [TypeChecking=Unrestricted] use in Source/core/ (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, shans, vivekg_samsung, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, yurys+blink_chromium.org, vivekg, nessy, apavlov+blink_chromium.org, loislo+blink_chromium.org, Steve Block, rwlbuis, caseq+blink_chromium.org, aandrey+blink_chromium.org, arv+blink, blink-reviews-dom_chromium.org, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Timothy Loh, Justin Novosad, dstockwell, dglazkov+blink, Rik, devtools-reviews_chromium.org, Eric Willigers, philipj_slow, rjwright, sof, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, feature-media-reviews_chromium.org, darktears, vcarbune.chromium, eustas+blink_chromium.org, blink-reviews-animation_chromium.org, gasubic, Mike Lawther (Google), ed+blinkwatch_opera.com, Inactive, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove [TypeChecking=Unrestricted] use in Source/core/ The IDL compiler has been updated to always generate code that rejects non-finite numbers, so removing [TypeChecking=Unrestricted] does not change generated code. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -51 lines) Patch
M Source/core/animation/AnimationPlayer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationTimeline.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationTimingProperties.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/animation/ComputedTimingProperties.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/animation/Timing.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/WebKitCSSMatrix.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DataView.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/events/AnimationPlayerEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/events/TransitionEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/events/WebKitAnimationEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/events/WheelEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMeterElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLProgressElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/MediaController.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasGradient.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegion.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/DevToolsHost.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/InternalDictionary.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-02 15:52:23 UTC) #2
fs
lgtm
5 years, 9 months ago (2015-03-02 16:08:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973503002/1
5 years, 9 months ago (2015-03-02 16:08:56 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:08:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191118

Powered by Google App Engine
This is Rietveld 408576698