Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: content/renderer/media/media_stream_video_source.h

Issue 973373002: fix for builds with webrtc disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move int const values to media_stream_video_source.h Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_video_source.h
diff --git a/content/renderer/media/media_stream_video_source.h b/content/renderer/media/media_stream_video_source.h
index ba66e439cdf9f1b42db9a96de2d8e4a76cef4b93..207c1e80748bc1b72c628f8179bee4797057ede4 100644
--- a/content/renderer/media/media_stream_video_source.h
+++ b/content/renderer/media/media_stream_video_source.h
@@ -78,10 +78,10 @@ class CONTENT_EXPORT MediaStreamVideoSource
// Default resolution. If no constraints are specified and the delegate
// support it, this is the resolution that will be used.
- static const int kDefaultWidth;
- static const int kDefaultHeight;
- static const int kDefaultFrameRate;
- static const int kUnknownFrameRate;
+ static const int kDefaultWidth = 640;
DaleCurtis 2015/03/04 21:26:04 Because you don't want static values in a header f
Mostyn Bramley-Moore 2015/03/04 21:49:39 I figured since it was only a few ints (as opposed
DaleCurtis 2015/03/04 21:54:23 It depends on how they're used; in the majority of
Mostyn Bramley-Moore 2015/03/04 21:57:39 OK. I will try to eliminate the need for this lat
+ static const int kDefaultHeight = 480;
+ static const int kDefaultFrameRate = 30;
+ static const int kUnknownFrameRate = 0;
protected:
void DoStopSource() override;
« no previous file with comments | « no previous file | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698