content/renderer/media/media_stream_video_source_constants.cc - Issue 973373002: fix for builds with webrtc disabled

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/media/media_stream_video_source_constants.cc

Issue 973373002: fix for builds with webrtc disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: leave a TODO note Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/renderer/media/media_stream_video_source.h"

	6

	7 // TODO(mostynb): refactor webrtc code and move these back

	8 // into media_stream_video_source.cc - crbug.com/463829

	9

	10 namespace content {

	11

	12 const int MediaStreamVideoSource::kDefaultWidth = 640;
	DaleCurtis 2015/03/04 19:21:30 Why not just stick these as enum {} in a shared he Why not just stick these as enum {} in a shared header? No need to make them static consts. Mostyn Bramley-Moore 2015/03/04 20:23:47 Actually why not keep them as static consts, but w Show quoted text On 2015/03/04 19:21:30, DaleCurtis wrote: > Why not just stick these as enum {} in a shared header? No need to make them > static consts. Actually why not keep them as static consts, but with the values in media_stream_video_source.h? (Done in the latest patchset.)
	13 const int MediaStreamVideoSource::kDefaultHeight = 480;

	14 const int MediaStreamVideoSource::kDefaultFrameRate = 30;

	15 const int MediaStreamVideoSource::kUnknownFrameRate = 0;

	16

	17 } // namespace content

OLD	NEW