Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 973333002: Remove Hangout Remote Desktop integration code from the webapp. (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
garykac, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Hangout Remote Desktop integration code from the webapp. Cleaning the webapp as the Hangout Remote Desktop service has discontinued. BUG=463322 Committed: https://crrev.com/96024224b1f0d9c9d824a76eefbd8d33d0ce517b Cr-Commit-Position: refs/heads/master@{#319009}

Patch Set 1 #

Patch Set 2 : Rebase + manifest changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1635 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 3 chunks +0 lines, -7 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M remoting/webapp/base/html/main.css View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/webapp/base/js/application.js View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/background.js View 3 chunks +0 lines, -26 lines 0 comments Download
M remoting/webapp/crd/js/client_screen.js View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/crd_main.js View 1 chunk +0 lines, -16 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 chunk +0 lines, -4 lines 0 comments Download
D remoting/webapp/crd/js/hangout_session.js View 1 chunk +0 lines, -81 lines 0 comments Download
D remoting/webapp/crd/js/it2me_helpee_channel.js View 1 1 chunk +0 lines, -472 lines 0 comments Download
D remoting/webapp/crd/js/it2me_helper_channel.js View 1 chunk +0 lines, -327 lines 0 comments Download
D remoting/webapp/crd/js/it2me_service.js View 1 chunk +0 lines, -178 lines 0 comments Download
M remoting/webapp/crd/manifest.json.jinja2 View 1 1 chunk +0 lines, -5 lines 0 comments Download
D remoting/webapp/unittests/it2me_helpee_channel_unittest.js View 1 1 chunk +0 lines, -168 lines 0 comments Download
D remoting/webapp/unittests/it2me_helper_channel_unittest.js View 1 chunk +0 lines, -194 lines 0 comments Download
D remoting/webapp/unittests/it2me_service_unittest.js View 1 chunk +0 lines, -137 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-03-03 23:36:44 UTC) #2
dcaiafa
lgtm. Thanks!
5 years, 9 months ago (2015-03-03 23:50:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973333002/20001
5 years, 9 months ago (2015-03-04 02:12:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 02:55:12 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:55:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96024224b1f0d9c9d824a76eefbd8d33d0ce517b
Cr-Commit-Position: refs/heads/master@{#319009}

Powered by Google App Engine
This is Rietveld 408576698