Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5202)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index be0c25e5273047dd4abbe4743b69fae726df5178..96d6e1f1eba3fa48d61c1677352ae54bbc325371 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -47,6 +47,10 @@ struct ItemInfo;
struct ItemInspectView;
struct ProjectInfo;
+namespace RequestFileSource {
+struct Params;
+}
+
} // namespace developer_private
} // namespace api
@@ -433,36 +437,32 @@ class DeveloperPrivateLoadDirectoryFunction
};
class DeveloperPrivateRequestFileSourceFunction
- : public ChromeAsyncExtensionFunction {
+ : public DeveloperPrivateAPIFunction {
public:
DECLARE_EXTENSION_FUNCTION("developerPrivate.requestFileSource",
DEVELOPERPRIVATE_REQUESTFILESOURCE);
-
DeveloperPrivateRequestFileSourceFunction();
protected:
~DeveloperPrivateRequestFileSourceFunction() override;
-
- // ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
private:
- void LaunchCallback(const base::DictionaryValue& results);
+ void Finish(const std::string& file_contents);
+
+ scoped_ptr<api::developer_private::RequestFileSource::Params> params_;
};
class DeveloperPrivateOpenDevToolsFunction
- : public ChromeAsyncExtensionFunction {
+ : public DeveloperPrivateAPIFunction {
public:
DECLARE_EXTENSION_FUNCTION("developerPrivate.openDevTools",
DEVELOPERPRIVATE_OPENDEVTOOLS);
-
DeveloperPrivateOpenDevToolsFunction();
protected:
~DeveloperPrivateOpenDevToolsFunction() override;
-
- // ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
};
} // namespace api

Powered by Google App Engine
This is Rietveld 408576698