Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: mojo/public/dart/src/application.dart

Issue 973293002: Gets dart working with new Application::AcceptConnection param (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/dart/test/echo/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/src/application.dart
diff --git a/mojo/public/dart/src/application.dart b/mojo/public/dart/src/application.dart
index 3ae900b5ce884a95669d031425ee1b1cc07ccf07..6e61df68c8f9bd2547b9c54ad04c3c8bb79687fe 100644
--- a/mojo/public/dart/src/application.dart
+++ b/mojo/public/dart/src/application.dart
@@ -31,10 +31,13 @@ class _ApplicationImpl implements application_mojom.Application {
_application.initialize(args, url);
}
+ @override
void acceptConnection(String requestorUrl, ServiceProviderStub services,
- bindings.ProxyBase exposedServices, String requested_url) =>
- _application._acceptConnection(requestorUrl, services, exposedServices);
+ bindings.ProxyBase exposedServices, String resolvedUrl) =>
sky 2015/03/03 22:48:54 I'm not particularly thrilled about resolvedUrl, b
+ _application._acceptConnection(requestorUrl, services, exposedServices,
+ resolvedUrl);
+ @override
void requestQuit() => _application._requestQuitAndClose();
void close({bool nodefer: false}) => shell.close();
@@ -96,15 +99,16 @@ abstract class Application {
}
void _acceptConnection(String requestorUrl, ServiceProviderStub services,
- ServiceProviderProxy exposedServices) {
+ ServiceProviderProxy exposedServices, String resolvedUrl) {
var connection = new ApplicationConnection(services, exposedServices);
_applicationConnections.add(connection);
- acceptConnection(requestorUrl, connection);
+ acceptConnection(requestorUrl, resolvedUrl, connection);
}
// Override this method to provide services on |connection|.
// If you provide at least one service or set fallbackServiceProvider,
// then you must invoke connection.listen().
- void acceptConnection(String requestorUrl, ApplicationConnection connection) {
+ void acceptConnection(String requestorUrl, String resolvedUrl,
+ ApplicationConnection connection) {
}
}
« no previous file with comments | « no previous file | services/dart/test/echo/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698