Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 973293002: Gets dart working with new Application::AcceptConnection param (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
Reviewers:
hansmuller, hansmuller1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M mojo/public/dart/src/application.dart View 2 chunks +9 lines, -5 lines 1 comment Download
M services/dart/test/echo/main.dart View 1 chunk +3 lines, -1 line 0 comments Download
M services/dart/test/pingpong/main.dart View 1 chunk +3 lines, -1 line 0 comments Download
M services/dart/test/pingpong_target/main.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
sky
I'm not sure why the dart tests were working without this... https://codereview.chromium.org/973293002/diff/1/mojo/public/dart/src/application.dart File mojo/public/dart/src/application.dart (right): ...
5 years, 9 months ago (2015-03-03 22:48:54 UTC) #1
hansmuller1
LGTM
5 years, 9 months ago (2015-03-03 23:02:15 UTC) #3
sky
5 years, 9 months ago (2015-03-03 23:04:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11fecd7ef30a4cd3def94f26f93c0f25c250e0d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698