Issue 973293002: Gets dart working with new Application::AcceptConnection param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 973293002: Gets dart working with new Application::AcceptConnection param (Closed)

Created:
5 years, 9 months ago by sky

Modified:
5 years, 9 months ago

Reviewers:
hansmuller, hansmuller1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Gets dart working with new Application::AcceptConnection param R=hansmuller@google.com, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/11fecd7ef30a4cd3def94f26f93c0f25c250e0d4

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -8 lines)			Patch
M	mojo/public/dart/src/application.dart	View	2 chunks	+9 lines, -5 lines	1 comment	Download
M	services/dart/test/echo/main.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	services/dart/test/pingpong/main.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	services/dart/test/pingpong_target/main.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sky

I'm not sure why the dart tests were working without this... https://codereview.chromium.org/973293002/diff/1/mojo/public/dart/src/application.dart File mojo/public/dart/src/application.dart (right): ...

5 years, 9 months ago (2015-03-03 22:48:54 UTC) #1

sky

5 years, 9 months ago (2015-03-03 23:04:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
11fecd7ef30a4cd3def94f26f93c0f25c250e0d4 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages