Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 973283002: Add EnhancedBookmark Command Line flag in Java (Closed)

Created:
5 years, 9 months ago by Ian Wen
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EnhancedBookmark Command Line flag in Java Enhanced Bookmark feature may need to be turned on by some java instrumental tests. Therefore the flag should be added to the java command line class. BUG=458632 Committed: https://crrev.com/8d4dd86fc31b1694dbc26c9ec60dee602395edcc Cr-Commit-Position: refs/heads/master@{#319096}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Did a change to isEditEnabled, to let it not crash in tests #

Patch Set 3 : Add rolling compat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Ian Wen
5 years, 9 months ago (2015-03-03 22:45:21 UTC) #2
Kibeom Kim (inactive)
https://codereview.chromium.org/973283002/diff/1/chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java File chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java (right): https://codereview.chromium.org/973283002/diff/1/chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java#newcode112 chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java:112: /** Enable enhanced bookmarks feature. */ Let's add * ...
5 years, 9 months ago (2015-03-03 22:48:27 UTC) #3
Kibeom Kim (inactive)
lgtm
5 years, 9 months ago (2015-03-03 22:48:33 UTC) #4
newt (away)
lgtm after kkimlab's comment
5 years, 9 months ago (2015-03-03 22:53:08 UTC) #5
Ian Wen
https://codereview.chromium.org/973283002/diff/1/chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java File chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java (right): https://codereview.chromium.org/973283002/diff/1/chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java#newcode112 chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java:112: /** Enable enhanced bookmarks feature. */ On 2015/03/03 22:48:27, ...
5 years, 9 months ago (2015-03-04 18:16:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973283002/40001
5 years, 9 months ago (2015-03-04 18:38:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 19:16:30 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:17:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d4dd86fc31b1694dbc26c9ec60dee602395edcc
Cr-Commit-Position: refs/heads/master@{#319096}

Powered by Google App Engine
This is Rietveld 408576698