Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 973263002: Chromecast: Fix build in chromecast_media_renderer_factory.cc (Closed)

Created:
5 years, 9 months ago by servolk
Modified:
5 years, 9 months ago
Reviewers:
lcwu1, lcwu, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: Fix build in chromecast_media_renderer_factory.cc BUG=none Committed: https://crrev.com/0bf9ad1d1bef7c2c843a8f69c02d5889827ba841 Cr-Commit-Position: refs/heads/master@{#318975}

Patch Set 1 #

Patch Set 2 : Added waiting_for_decryption_key_cb parameter to switching renderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chromecast/media/base/switching_media_renderer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/media/base/switching_media_renderer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/renderer/media/chromecast_media_renderer_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
servolk
5 years, 9 months ago (2015-03-03 22:29:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973263002/1
5 years, 9 months ago (2015-03-03 22:30:01 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-03 22:30:06 UTC) #6
servolk
5 years, 9 months ago (2015-03-03 22:31:56 UTC) #8
lcwu1
lgtm
5 years, 9 months ago (2015-03-03 22:32:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973263002/1
5 years, 9 months ago (2015-03-03 22:34:57 UTC) #12
gunsch
On 2015/03/03 22:34:57, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-03 23:12:11 UTC) #13
servolk
On 2015/03/03 23:12:11, gunsch wrote: > On 2015/03/03 22:34:57, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-03 23:51:29 UTC) #14
gunsch
On 2015/03/03 23:51:29, servolk wrote: > On 2015/03/03 23:12:11, gunsch wrote: > > On 2015/03/03 ...
5 years, 9 months ago (2015-03-03 23:53:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973263002/20001
5 years, 9 months ago (2015-03-03 23:55:07 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 00:21:46 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:22:20 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bf9ad1d1bef7c2c843a8f69c02d5889827ba841
Cr-Commit-Position: refs/heads/master@{#318975}

Powered by Google App Engine
This is Rietveld 408576698