cc: Scale checkerboard quads by the device scale factor.

cc: Scale checkerboard quads by the device scale factor.

This adds pixel tests for checkerboard quads to verify we're able to
draw them, and another test where the quad is scaled.

R=enne, vmpstr
BUG=169624
Committed: https://crrev.com/e1419ce4eee9e8067ec30853d3bab4a9415aefe4
Cr-Commit-Position: refs/heads/master@{#319131}

[danakj, 2015-03-03 21:24:21]

danakj@chromium.org changed reviewers:
+ kenrb@chromium.org

[danakj, 2015-03-03 21:24:22]

+kenrb for cc_messages

[kenrb, 2015-03-03 21:47:28]

ipc lgtm

[vmpstr, 2015-03-03 22:13:46]

https://codereview.chromium.org/973223002/diff/1/cc/layers/tiled_layer_impl.cc
File cc/layers/tiled_layer_impl.cc (right):

https://codereview.chromium.org/973223002/diff/1/cc/layers/tiled_layer_impl.c...
cc/layers/tiled_layer_impl.cc:245: visible_tile_rect, checker_color, 1.f);
Why 1 here?

[danakj, 2015-03-03 22:31:26]

Oh I need to include the .pngs, but these tests are overly simplistic with only
1 checkerboard quad, I'm going to make them a bit better.

[danakj, 2015-03-03 22:41:14]

https://codereview.chromium.org/973223002/diff/1/cc/layers/tiled_layer_impl.cc
File cc/layers/tiled_layer_impl.cc (right):

https://codereview.chromium.org/973223002/diff/1/cc/layers/tiled_layer_impl.c...
cc/layers/tiled_layer_impl.cc:245: visible_tile_rect, checker_color, 1.f);
On 2015/03/03 22:13:46, vmpstr wrote:
> Why 1 here?

Just to preserve existing behaviour. Also we don't ever see tiled layer
checkerboards at this point.

[danakj, 2015-03-04 00:47:17]

PTAL

[danakj, 2015-03-04 00:47:24]

Patchset #2 (id:20001) has been deleted

[danakj, 2015-03-04 00:47:36]

Patchset #2 (id:20001) has been deleted

[vmpstr, 2015-03-04 00:53:56]

https://codereview.chromium.org/973223002/diff/40001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:317: break;
Debugging?

https://codereview.chromium.org/973223002/diff/40001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:568: float tex_offset_y =
Should the type of this be int as well?

https://codereview.chromium.org/973223002/diff/40001/cc/output/renderer_pixel...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/output/renderer_pixel...
cc/output/renderer_pixeltest.cc:2538: ? "four_blue_green_checkers.png"
I don't see this file included in this patch, does it already exist?

[danakj, 2015-03-04 17:06:57]

https://codereview.chromium.org/973223002/diff/40001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:317: break;
On 2015/03/04 00:53:56, vmpstr wrote:
> Debugging?

*^_^*

https://codereview.chromium.org/973223002/diff/40001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:568: float tex_offset_y =
On 2015/03/04 00:53:56, vmpstr wrote:
> Should the type of this be int as well?

It gets converted to a float when passed to Uniform4f, so I don't think it
matters.. kinda prefer to leave it?

https://codereview.chromium.org/973223002/diff/40001/cc/output/renderer_pixel...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/973223002/diff/40001/cc/output/renderer_pixel...
cc/output/renderer_pixeltest.cc:2538: ? "four_blue_green_checkers.png"
On 2015/03/04 00:53:56, vmpstr wrote:
> I don't see this file included in this patch, does it already exist?

It already exists yes.

[danakj, 2015-03-04 17:08:23]

PTAL

[vmpstr, 2015-03-04 17:22:30]

lgtm

https://codereview.chromium.org/973223002/diff/60001/cc/quads/checkerboard_dr...
File cc/quads/checkerboard_draw_quad.h (right):

https://codereview.chromium.org/973223002/diff/60001/cc/quads/checkerboard_dr...
cc/quads/checkerboard_draw_quad.h:34: float scale;
nit: initialize in the ctor please.

[danakj, 2015-03-04 17:23:49]

https://codereview.chromium.org/973223002/diff/60001/cc/quads/checkerboard_dr...
File cc/quads/checkerboard_draw_quad.h (right):

https://codereview.chromium.org/973223002/diff/60001/cc/quads/checkerboard_dr...
cc/quads/checkerboard_draw_quad.h:34: float scale;
On 2015/03/04 17:22:30, vmpstr wrote:
> nit: initialize in the ctor please.

Done. thanks!

[danakj, 2015-03-04 17:24:14]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-04 17:24:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/973223002/#ps80001 (title:
"checkerboardscale: init")

[commit-bot: I haz the power, 2015-03-04 17:24:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973223002/80001

[commit-bot: I haz the power, 2015-03-04 19:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 19:48:18]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[danakj, 2015-03-04 20:19:34]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-04 20:19:35]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/973223002/#ps100001
(title: "checkerboardscale: fixwindowsbuild")

[commit-bot: I haz the power, 2015-03-04 20:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973223002/100001

[commit-bot: I haz the power, 2015-03-04 21:26:52]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-03-04 21:27:20]

Patchset 5 (id:??) landed as
https://crrev.com/e1419ce4eee9e8067ec30853d3bab4a9415aefe4
Cr-Commit-Position: refs/heads/master@{#319131}