Adds extension events for custom dictionary load/change.

chrome/browser/chromeos/extensions/dictionary_event_router.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[please use gerrit instead, 2015/03/05 21:42:51]

2015

[Peter Wen, 2015/03/06 16:09:09]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_DICTIONARY_EVENT_ROUTER_H_
+#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_DICTIONARY_EVENT_ROUTER_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "chrome/browser/spellchecker/spellcheck_custom_dictionary.h"
+
+namespace content {
+class BrowserContext;
+}
+
+namespace chromeos {
+
+// Event router class for custom dictionary events.
+class ExtensionDictionaryEventRouter
+    : public SpellcheckCustomDictionary::Observer {
+ public:
+  explicit ExtensionDictionaryEventRouter(content::BrowserContext* context);
+  virtual ~ExtensionDictionaryEventRouter();

[please use gerrit instead, 2015/03/05 21:42:52]

I think we've changed from "vurtual ~ClassName();" to "~ClassName() override;"
for destructors.

[Peter Wen, 2015/03/06 16:09:09]

Since this class only inherits from Observer, and observer does not define a
destructor, There is nothing to override, and I need to create my own virtual
destructor.

Is there a better way?

[please use gerrit instead, 2015/03/06 17:54:34]

SGTM.

+
+  // SpellcheckCustomDictionary::Observer implementation.
+  void OnCustomDictionaryLoaded() override;
+  void OnCustomDictionaryChanged(
+      const SpellcheckCustomDictionary::Change& dictionary_change) override;
+
+ private:
+  content::BrowserContext* context_;
+  SpellcheckCustomDictionary* dictionary_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionDictionaryEventRouter);
+};
+
+}  // namespace chromeos
+#endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_DICTIONARY_EVENT_ROUTER_H_