Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 973003002: Fix crash in SimpleGeolocationProvider. (Closed)

Created:
5 years, 9 months ago by Alexander Alekseev
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in SimpleGeolocationProvider. BUG=463150 TEST=manual Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7 Cr-Commit-Position: refs/heads/master@{#318866} Committed: https://crrev.com/52c47d3ddd8cf5a4ce35ef68fc1951c8fc99c238 Cr-Commit-Position: refs/heads/master@{#318920}

Patch Set 1 #

Patch Set 2 : DCHECK crash fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chromeos/geolocation/simple_geolocation_provider.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M chromeos/timezone/timezone_provider.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Alexander Alekseev
It looks like std::remove cannot be used with ScopedVector. Please review.
5 years, 9 months ago (2015-03-03 12:40:14 UTC) #2
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-03 13:22:53 UTC) #3
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-03 13:22:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973003002/1
5 years, 9 months ago (2015-03-03 13:23:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 13:58:41 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7 Cr-Commit-Position: refs/heads/master@{#318866}
5 years, 9 months ago (2015-03-03 13:59:51 UTC) #8
ulan
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/974883002/ by ulan@chromium.org. ...
5 years, 9 months ago (2015-03-03 14:36:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973003002/20001
5 years, 9 months ago (2015-03-03 18:14:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 18:57:34 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 18:58:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52c47d3ddd8cf5a4ce35ef68fc1951c8fc99c238
Cr-Commit-Position: refs/heads/master@{#318920}

Powered by Google App Engine
This is Rietveld 408576698