Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 972983003: ChromeOS DBus: leaderd API (Closed)

Created:
5 years, 9 months ago by dtapuska
Modified:
5 years, 9 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS DBus: leaderd API We adjusted the leaderd dbus API to pass back an ObjectPath instead of a string. Adjust the chromium bindings to match that. BUG=453872 Committed: https://crrev.com/a40f2740e4db81134f9c8b386c75c10c47279e1a Cr-Commit-Position: refs/heads/master@{#318876}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix minor nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M chromeos/dbus/fake_leadership_daemon_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_leadership_daemon_manager_client.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M chromeos/dbus/leadership_daemon_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/leadership_daemon_manager_client.cc View 5 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dtapuska
5 years, 9 months ago (2015-03-03 14:38:58 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/972983003/diff/1/chromeos/dbus/fake_leadership_daemon_manager_client.cc File chromeos/dbus/fake_leadership_daemon_manager_client.cc (right): https://codereview.chromium.org/972983003/diff/1/chromeos/dbus/fake_leadership_daemon_manager_client.cc#newcode24 chromeos/dbus/fake_leadership_daemon_manager_client.cc:24: } nit: Please add "// namespace" here while ...
5 years, 9 months ago (2015-03-03 14:53:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972983003/20001
5 years, 9 months ago (2015-03-03 14:58:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 15:37:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 15:38:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a40f2740e4db81134f9c8b386c75c10c47279e1a
Cr-Commit-Position: refs/heads/master@{#318876}

Powered by Google App Engine
This is Rietveld 408576698