Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 972973002: Revert of Propagate audible state from player to the containing tab (Closed)

Created:
5 years, 9 months ago by aberent
Modified:
5 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Propagate audible state from player to the containing tab (patchset #16 id:310001 of https://codereview.chromium.org/896673003/) Reason for revert: This (Android only) change breaks the downstream Android test CastSwitchVideoTest#testNewVideoNewPageSameTab. Reverting as Android Sheriff. BUG=463445 Original issue's description: > Propagate audible state from player to the containing tab. > > This is part 1 (chromium), > part 2 (clank) is https://chrome-internal-review.googlesource.com/#/c/195455/ > > This CL is only about propagation/plumbing. > Neither the reporting of audible state my players nor the consumption > (UI notification) are implemented. > > This patch creates a new object AudioMonitorAndroid and > attaches it to MediaWebContentsObserver. The AudioMonitorAndroid > maintains the audible state for the tab. It receives notifications > from MediaPlayerAndroid objects and sends the resulting > notification to the WebContents. > > BUG=414810 > > Committed: https://crrev.com/6ad356d3e845ed9b67c5fb799b2ee8290f317268 > Cr-Commit-Position: refs/heads/master@{#318823} TBR=qinmin@chromium.org,sievers@chromium.org,tedchoc@chromium.org,aurimas@chromium.org,timav@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414810 Committed: https://crrev.com/6232fa583f944ee5f52be99b6eb9cee6fd3fdeb8 Cr-Commit-Position: refs/heads/master@{#318862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -373 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D content/browser/android/media_players_observer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/android/media_players_observer.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 6 chunks +3 lines, -13 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 5 chunks +4 lines, -15 lines 0 comments Download
D content/browser/media/audio_state_provider.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/media/audio_state_provider.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/media/audio_stream_monitor.h View 6 chunks +21 lines, -8 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 4 chunks +13 lines, -22 lines 0 comments Download
M content/browser/media/audio_stream_monitor_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 4 chunks +2 lines, -22 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +6 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 7 chunks +5 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/media_player_android.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/android/media_player_android.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 4 chunks +8 lines, -23 lines 0 comments Download
M media/base/android/media_player_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
aberent
Created Revert of Propagate audible state from player to the containing tab
5 years, 9 months ago (2015-03-03 11:21:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972973002/1
5 years, 9 months ago (2015-03-03 11:26:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 11:28:13 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 11:29:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6232fa583f944ee5f52be99b6eb9cee6fd3fdeb8
Cr-Commit-Position: refs/heads/master@{#318862}

Powered by Google App Engine
This is Rietveld 408576698