Per-renderer WebSocket throttling

content/browser/renderer_host/websocket_dispatcher_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_WEBSOCKET_DISPATCHER_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_WEBSOCKET_DISPATCHER_HOST_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/containers/hash_tables.h"
+#include "base/timer/timer.h"
 #include "content/common/content_export.h"
 #include "content/common/websocket.h"
 #include "content/public/browser/browser_message_filter.h"
 
 namespace net {
 class URLRequestContext;
 }  // namespace net
 
 namespace content {
 
 struct WebSocketHandshakeRequest;
 struct WebSocketHandshakeResponse;
 class WebSocketHost;
 
 // Creates a WebSocketHost object for each WebSocket channel, and dispatches
 // WebSocketMsg_* messages sent from renderer to the appropriate WebSocketHost.
 class CONTENT_EXPORT WebSocketDispatcherHost : public BrowserMessageFilter {
  public:
   typedef base::Callback<net::URLRequestContext*()> GetRequestContextCallback;
 
-  // Given a routing_id, WebSocketHostFactory returns a new instance of
-  // WebSocketHost or its subclass.
-  typedef base::Callback<WebSocketHost*(int)> WebSocketHostFactory;  // NOLINT
+  // Given a routing_id and delay_in_ms, WebSocketHostFactory returns a new
+  // instance of WebSocketHost or its subclass.
+  typedef base::Callback<WebSocketHost*(int, int)> WebSocketHostFactory;
 
   // Return value for methods that may delete the WebSocketHost. This enum is
   // binary-compatible with net::WebSocketEventInterface::ChannelState, to make
   // conversion cheap. By using a separate enum including net/ header files can
   // be avoided.
   enum WebSocketHostState {
     WEBSOCKET_HOST_ALIVE,
     WEBSOCKET_HOST_DELETED
   };
 
@@ skipping 63 matching lines @@
   // Returns whether the associated renderer process can read raw cookies.
   bool CanReadRawCookies() const;
 
   int render_process_id() const { return process_id_; }
 
  private:
   typedef base::hash_map<int, WebSocketHost*> WebSocketHostTable;
 
   ~WebSocketDispatcherHost() override;
 
-  WebSocketHost* CreateWebSocketHost(int routing_id);
+  WebSocketHost* CreateWebSocketHost(int routing_id, int delay_in_ms);
 
   // Looks up a WebSocketHost object by |routing_id|. Returns the object if one
   // is found, or NULL otherwise.
   WebSocketHost* GetHost(int routing_id) const;
 
   // Sends the passed in IPC::Message via the BrowserMessageFilter::Send()
   // method. If sending the IPC fails, assumes that this connection is no
   // longer useable, calls DeleteWebSocketHost(), and returns
   // WEBSOCKET_HOST_DELETED. The behaviour is the same for all message types.
   WebSocketHostState SendOrDrop(IPC::Message* message) WARN_UNUSED_RESULT;
 
   // Deletes the WebSocketHost object associated with the given |routing_id| and
   // removes it from the |hosts_| table.
   void DeleteWebSocketHost(int routing_id);
 
+  // Calculate delay for Per-renderer WebSocket throttling.
+  int64 CalculateDelayInMs() const;

[Adam Rice, 2015/03/03 15:10:02]

This method could return a base::TimeDelta object, then it wouldn't need to
specify "InMs" in the name.

[hiroshige, 2015/03/04 06:02:37]

Done.

+
+  // FIXME
+  void FinishThrottlingPeriod();

[Adam Rice, 2015/03/03 15:10:02]

This is not a very clear name for the method. Maybe
"UpdateSuccessFailureCountsTimerCallback()"? Okay, that's not a great name
either.

[hiroshige, 2015/03/04 06:02:37]

How about "ThrottlingPeriodTimerCallback()" (and changing timer_ to
throttling_period_timer_)?

[Adam Rice, 2015/03/04 08:20:49]

Sounds good to me.

[hiroshige, 2015/03/04 11:13:14]

Done.

+
   // Table of WebSocketHost objects, owned by this object, indexed by
   // routing_id.
   WebSocketHostTable hosts_;
 
   // The the process ID of the associated renderer process.
   const int process_id_;
 
   // A callback which returns the appropriate net::URLRequestContext for us to
   // use.
   GetRequestContextCallback get_context_callback_;
 
   WebSocketHostFactory websocket_host_factory_;
 
+  // Timer and counters for Per-renderer WebSocket throttling.

[Adam Rice, 2015/03/03 15:10:02]

Nitpick: The P of per-renderer should be lowercase.

[hiroshige, 2015/03/04 06:02:37]

Done.

+  base::RepeatingTimer<WebSocketDispatcherHost> timer_;

[Adam Rice, 2015/03/03 15:10:02]

A slightly more specific name might be better, like counting_period_timer_.

[hiroshige, 2015/03/04 11:13:14]

Done.

+  // The current number of pending connections.
+  int num_pending_connections_;
+  // The number of handshakes that failed in the current and previous time
+  // period.
+  int num_current_succeeded_connections_;
+  int num_previous_succeeded_connections_;
+  // The number of handshakes that succeeded in the current and previous time
+  // period.
+  int num_current_failed_connections_;
+  int num_previous_failed_connections_;
+
   DISALLOW_COPY_AND_ASSIGN(WebSocketDispatcherHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_WEBSOCKET_DISPATCHER_HOST_H_