Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 972833002: Apply a prettier background for platforms that don't support shaped windows. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply a prettier background for platforms that don't support shaped windows. BUG=b/19370387 Committed: https://crrev.com/72d660649891203dac837d0ddc0d71bb2bd1988d Cr-Commit-Position: refs/heads/master@{#318833}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + remoting/webapp/app_remoting/html/ar_main.css View 1 1 chunk +5 lines, -4 lines 0 comments Download
M remoting/webapp/app_remoting/html/template_lg.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Jamie
ptal
5 years, 9 months ago (2015-03-02 23:52:54 UTC) #2
garykac
https://codereview.chromium.org/972833002/diff/1/remoting/app_remoting_webapp_files.gypi File remoting/app_remoting_webapp_files.gypi (right): https://codereview.chromium.org/972833002/diff/1/remoting/app_remoting_webapp_files.gypi#newcode9 remoting/app_remoting_webapp_files.gypi:9: 'webapp/app_remoting/html/ar_main.css', New file?
5 years, 9 months ago (2015-03-03 00:44:10 UTC) #3
Jamie
https://codereview.chromium.org/972833002/diff/1/remoting/app_remoting_webapp_files.gypi File remoting/app_remoting_webapp_files.gypi (right): https://codereview.chromium.org/972833002/diff/1/remoting/app_remoting_webapp_files.gypi#newcode9 remoting/app_remoting_webapp_files.gypi:9: 'webapp/app_remoting/html/ar_main.css', On 2015/03/03 00:44:10, garykac wrote: > New file? ...
5 years, 9 months ago (2015-03-03 00:47:11 UTC) #4
garykac
lgtm
5 years, 9 months ago (2015-03-03 00:58:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972833002/20001
5 years, 9 months ago (2015-03-03 01:17:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 03:29:43 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:30:18 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/72d660649891203dac837d0ddc0d71bb2bd1988d
Cr-Commit-Position: refs/heads/master@{#318833}

Powered by Google App Engine
This is Rietveld 408576698