Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 972773003: Make sure the --site-per-process flag is present for subframe process swaps. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure the --site-per-process flag is present for subframe process swaps. (Attempt #2, after a speculative revert from a flaky test.) BUG=461494 TEST=Crash report should show that --site-per-process flag is present. Committed: https://crrev.com/a741b8a36ac9eecf6bad6a324fcfc66a35a521cb Cr-Commit-Position: refs/heads/master@{#318798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/loader/cross_site_resource_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Alex: Perhaps we should try again? I don't see how this could cause the Asan ...
5 years, 9 months ago (2015-03-02 22:28:38 UTC) #2
alexmos
LGTM. Hope it sticks this time.
5 years, 9 months ago (2015-03-02 22:34:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972773003/1
5 years, 9 months ago (2015-03-02 22:52:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 23:42:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:43:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a741b8a36ac9eecf6bad6a324fcfc66a35a521cb
Cr-Commit-Position: refs/heads/master@{#318798}

Powered by Google App Engine
This is Rietveld 408576698