Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 972743003: Revert of Add SkCodec, including PNG implementation. (Closed)

Created:
5 years, 9 months ago by scroggo
Modified:
5 years, 9 months ago
Reviewers:
msarett, djsollen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkCodec, including PNG implementation. (patchset #24 id:460001 of https://codereview.chromium.org/930283002/) Reason for revert: Breaking windows bots all over the place :( Original issue's description: > Add SkCodec, including PNG implementation. > > DM: > Add a flag to use SkCodec instead of SkImageDecoder. > > SkCodec: > Base class for codecs, allowing creation from an SkStream or an SkData. > An SkCodec, on creation, knows properties of the data like its width and height. Further calls can be used to generate the image. > TODO: Add scanline iterator > > SkPngCodec: > New decoder for png. Wraps libpng. The code has been repurposed from SkImageDecoder_libpng. > TODO: Handle other destination colortypes > TODO: Substitute the transpose color > TODO: Allow silencing warnings > TODO: Use RGB instead of filler? > TODO: sRGB > > SkSwizzler: > Simplified version of SkScaledSampler. Unlike the sampler, this object does no sampling. > TODO: Implement other swizzles. > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/ca358852b4fed656d11107b2aaf28318a4518b49 TBR=reed@google.com,djsollen@google.com,msarett@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/ee1a726aed980016a9371ffa4768e0844c360eb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1124 lines) Patch
M DEPS View 1 chunk +3 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 3 chunks +3 lines, -32 lines 0 comments Download
D gyp/codec.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
M gyp/common_variables.gypi View 2 chunks +5 lines, -10 lines 0 comments Download
D gyp/copy_file.py View 1 chunk +0 lines, -39 lines 0 comments Download
M gyp/libpng.gyp View 2 chunks +2 lines, -26 lines 0 comments Download
M gyp/skia_lib.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/codec/SkCodec.h View 1 chunk +0 lines, -92 lines 0 comments Download
D src/codec/SkCodec.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D src/codec/SkCodec_libpng.h View 1 chunk +0 lines, -34 lines 0 comments Download
D src/codec/SkCodec_libpng.cpp View 1 chunk +0 lines, -492 lines 0 comments Download
D src/codec/SkSwizzler.h View 1 chunk +0 lines, -94 lines 0 comments Download
D src/codec/SkSwizzler.cpp View 1 chunk +0 lines, -221 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Add SkCodec, including PNG implementation.
5 years, 9 months ago (2015-03-02 20:29:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972743003/1
5 years, 9 months ago (2015-03-02 20:31:01 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 20:31:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee1a726aed980016a9371ffa4768e0844c360eb2

Powered by Google App Engine
This is Rietveld 408576698