Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 972733003: Web MIDI: reset button in permission bubble does not work (Closed)

Created:
5 years, 9 months ago by Takashi Toyoshima
Modified:
5 years, 9 months ago
CC:
chromium-reviews, msramek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: reset button in permission bubble does not work Current implementation use ContentSettingsPattern::Wildcard() to reset a setting for the current visiting page, but it does not work. This should be the embedder URL as geolocation does. BUG=460733 TEST=manual Committed: bce86225d776104ba807a5d49cbb6772fa06a Cr-Commit-Position: refs/heads/master@{#318720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Takashi Toyoshima
Hi guys, how are you doing? Can you take a look this two lines change?
5 years, 9 months ago (2015-03-02 16:40:46 UTC) #2
Bernhard Bauer
lgtm
5 years, 9 months ago (2015-03-02 16:45:52 UTC) #3
Takashi Toyoshima
wow, thank you for a super quick review:)
5 years, 9 months ago (2015-03-02 16:56:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972733003/1
5 years, 9 months ago (2015-03-02 16:57:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 17:52:59 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:53:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/969bce86225d776104ba807a5d49cbb6772fa06a
Cr-Commit-Position: refs/heads/master@{#318720}

Powered by Google App Engine
This is Rietveld 408576698