Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 972683002: Upstream dom_distiller iOS factories (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@browser_state
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream dom_distiller iOS factories BUG=459678 R=noyau@chromium.org Committed: https://crrev.com/b1c474917d84b594df5915ddf7686460354a72b2 Cr-Commit-Position: refs/heads/master@{#318691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -1 line) Patch
M ios/chrome/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + ios/chrome/browser/dom_distiller/OWNER View 0 chunks +-1 lines, --1 lines 0 comments Download
A ios/chrome/browser/dom_distiller/distiller_viewer.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/dom_distiller/distiller_viewer.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
5 years, 9 months ago (2015-03-02 14:00:12 UTC) #1
noyau (Ping after 24h)
lgtm
5 years, 9 months ago (2015-03-02 14:25:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972683002/1
5 years, 9 months ago (2015-03-02 14:26:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972683002/1
5 years, 9 months ago (2015-03-02 14:36:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 14:59:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 14:59:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c474917d84b594df5915ddf7686460354a72b2
Cr-Commit-Position: refs/heads/master@{#318691}

Powered by Google App Engine
This is Rietveld 408576698