Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 972653002: [turbofan] Strength reduction of Word32And with Int32Mul. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Strength reduction of Word32And with Int32Mul. - (x * (K << L)) & (-1 << L) => x * (K << L) - ((K << L) * x) & (-1 << L) => x * (K << L) R=dcarney@chromium.org Committed: https://crrev.com/e1c2c9016e7033270fbc68b858591e51d1be560c Cr-Commit-Position: refs/heads/master@{#26942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-02 13:34:27 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-02 13:34:40 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-02 13:37:13 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as e1c2c9016e7033270fbc68b858591e51d1be560c (presubmit successful).
5 years, 9 months ago (2015-03-02 13:54:16 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 13:54:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1c2c9016e7033270fbc68b858591e51d1be560c
Cr-Commit-Position: refs/heads/master@{#26942}

Powered by Google App Engine
This is Rietveld 408576698