Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 972623003: convert more object functions to return maybes (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert more object functions to return maybes R=svenpanne@chromium.org BUG=v8:3929 LOG=y Committed: https://crrev.com/6130b02524059069413c1fccce5695c2802019b8 Cr-Commit-Position: refs/heads/master@{#26952}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -168 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 chunks +32 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 8 chunks +194 lines, -168 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
ptal i'm ooto tomorrow, so if the cq is working, please punch the cq button.
5 years, 9 months ago (2015-03-02 16:15:35 UTC) #2
Sven Panne
LGTM, although "auto" seems to be a bit overused, let's perhaps revisit this later.
5 years, 9 months ago (2015-03-03 07:10:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972623003/140001
5 years, 9 months ago (2015-03-03 07:11:53 UTC) #5
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-03-03 07:14:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:14:51 UTC) #7
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/6130b02524059069413c1fccce5695c2802019b8
Cr-Commit-Position: refs/heads/master@{#26952}

Powered by Google App Engine
This is Rietveld 408576698