Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 972563002: Fix nacl-only targets in gn_migration.gypi (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
tfarina, dshwang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nacl-only targets in gn_migration.gypi The 'nacl_loader_unittests' and 'remoting_key_tester' targets require nacl and should only be built when nacl is enabled. TBR=dongseong.hwang@intel.com, tfarina@chromium.org BUG=462945, 461019 Committed: https://crrev.com/ad333257fe8e7d9b632f728de5fe6db9feb9a64d Cr-Commit-Position: refs/heads/master@{#318631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/gn_migration.gypi View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972563002/1
5 years, 9 months ago (2015-03-01 20:22:52 UTC) #3
tfarina
lgtm
5 years, 9 months ago (2015-03-01 20:32:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-01 21:17:49 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 21:18:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad333257fe8e7d9b632f728de5fe6db9feb9a64d
Cr-Commit-Position: refs/heads/master@{#318631}

Powered by Google App Engine
This is Rietveld 408576698