Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 972493002: Sync the DOMStringMap interface with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the DOMStringMap interface with the spec https://html.spec.whatwg.org/#the-domstringmap-interface The spec IDL has [Exposed=(Window,Worker)], but that seems wrong: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28104 The creator keyword was not added: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28121 There are no changes to the generated code. BUG=460722, 462920 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191064

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop creator keyword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/dom/DOMStringMap.idl View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-01 04:44:03 UTC) #2
Jens Widell
LGTM, but I think we should drop "creator" (and report a spec bug about it.) ...
5 years, 9 months ago (2015-03-01 15:40:44 UTC) #3
philipj_slow
https://codereview.chromium.org/972493002/diff/1/Source/core/dom/DOMStringMap.idl File Source/core/dom/DOMStringMap.idl (right): https://codereview.chromium.org/972493002/diff/1/Source/core/dom/DOMStringMap.idl#newcode34 Source/core/dom/DOMStringMap.idl:34: [RaisesException] setter creator void (DOMString name, DOMString value); On ...
5 years, 9 months ago (2015-03-01 16:41:15 UTC) #4
philipj_slow
drop creator keyword
5 years, 9 months ago (2015-03-01 16:44:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972493002/20001
5 years, 9 months ago (2015-03-01 16:45:00 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 17:52:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191064

Powered by Google App Engine
This is Rietveld 408576698