Issue 972433004: Use the mojo::shell namespace consistently underly shell/.

Issue 972433004: Use the mojo::shell namespace consistently underly shell/. (Closed)

Created:
5 years, 9 months ago by viettrungluu

Modified:
5 years, 9 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Use the mojo::shell namespace consistently under shell/. (Esp. under shell/application_manager/.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/36faa4d1292b403dbc538c49f78bc934757f2df6

Patch Set 3 : Java! #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -42 lines)			Patch
M	services/window_manager/window_manager_api_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	shell/android/android_handler.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/android/android_handler.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/Bootstrap.java	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	shell/android/background_application_loader.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/android/background_application_loader.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/android/background_application_loader_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	shell/android/bootstrap.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	shell/android/library_loader.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/android/run_android_application_function.h	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	shell/android/ui_application_loader_android.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/android/ui_application_loader_android.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/application_manager/application_loader.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	shell/application_manager/application_manager.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/application_manager/application_manager.cc	View		5 chunks	+4 lines, -4 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View		6 chunks	+7 lines, -6 lines	0 comments	Download
M	shell/application_manager/fetcher.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	shell/application_manager/fetcher.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/application_manager/local_fetcher.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	shell/application_manager/local_fetcher.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/application_manager/network_fetcher.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	shell/application_manager/network_fetcher.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	shell/application_manager/shell_impl.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	shell/application_manager/shell_impl.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/application_manager/test.mojom	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/context.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	shell/filename_util.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/filename_util.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/launcher_main.cc	View		5 chunks	+8 lines, -6 lines	0 comments	Download
M	shell/native_runner_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	shell/shell_test_helper.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/972433004/diff/1/shell/application_manager/application_loader.h File shell/application_manager/application_loader.h (right): https://codereview.chromium.org/972433004/diff/1/shell/application_manager/application_loader.h#newcode18 shell/application_manager/application_loader.h:18: namespace shell { it should be just shell:: (or ...

5 years, 9 months ago (2015-03-05 01:08:45 UTC) #2

jamesr

Fix android "underly" -> under lgtm since the rest of shell/ is under mojo::shell:: now ...

5 years, 9 months ago (2015-03-05 01:14:04 UTC) #3

viettrungluu

5 years, 9 months ago (2015-03-05 02:08:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
36faa4d1292b403dbc538c49f78bc934757f2df6 (presubmit successful).

Expand Messages | Collapse Messages