Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 972433003: Upstream WebappDirectoryManager (Closed)

Created:
5 years, 9 months ago by gone
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream WebappDirectoryManager BUG=428907 Committed: https://crrev.com/78af6b39bd901c60fcc4e345dd0488fce9eb0439 Cr-Commit-Position: refs/heads/master@{#319290}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Patch Set 3 : Findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java View 1 2 1 chunk +167 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gone
5 years, 9 months ago (2015-03-05 00:53:06 UTC) #2
newt (away)
lgtm after comments https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java (right): https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java#newcode1 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:1: // Copyright 2014 The Chromium Authors. ...
5 years, 9 months ago (2015-03-05 01:18:30 UTC) #3
gone
https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java (right): https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java#newcode1 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-05 03:01:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972433003/20001
5 years, 9 months ago (2015-03-05 03:13:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/53271)
5 years, 9 months ago (2015-03-05 05:24:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972433003/40001
5 years, 9 months ago (2015-03-05 18:38:23 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-05 19:00:02 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 19:00:39 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78af6b39bd901c60fcc4e345dd0488fce9eb0439
Cr-Commit-Position: refs/heads/master@{#319290}

Powered by Google App Engine
This is Rietveld 408576698