Upstream WebappDirectoryManager

Upstream WebappDirectoryManager

BUG=428907
Committed: https://crrev.com/78af6b39bd901c60fcc4e345dd0488fce9eb0439
Cr-Commit-Position: refs/heads/master@{#319290}

[gone, 2015-03-05 00:53:06]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-03-05 01:18:30]

lgtm after comments

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java
(right):

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:66:
assert Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
why can you be sure that we're on Lollipop here?

[gone, 2015-03-05 03:01:37]

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java
(right):

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/03/05 01:18:30, newt wrote:
> 2015

Done.

https://codereview.chromium.org/972433003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:66:
assert Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
On 2015/03/05 01:18:30, newt wrote:
> why can you be sure that we're on Lollipop here?

That deleteOldDirectories boolean is set IFF the user can be in Document mode
via the downstream CL.

[gone, 2015-03-05 03:01:40]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-03-05 03:03:38]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-03-05 03:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/972433003/#ps20001 (title:
"Addressing comments")

[commit-bot: I haz the power, 2015-03-05 03:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/972433003/20001

[commit-bot: I haz the power, 2015-03-05 05:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 05:24:51]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[gone, 2015-03-05 18:37:57]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-03-05 18:37:57]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/972433003/#ps40001
(title: "Findbugs")

[commit-bot: I haz the power, 2015-03-05 18:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/972433003/40001

[commit-bot: I haz the power, 2015-03-05 19:00:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-05 19:00:39]

Patchset 3 (id:??) landed as
https://crrev.com/78af6b39bd901c60fcc4e345dd0488fce9eb0439
Cr-Commit-Position: refs/heads/master@{#319290}