snapshot/snapshot.gyp - Issue 972383002: snapshot: Add a minimal ModuleSnapshotMinidump and accessor from ProcessSnapshotMinidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/snapshot.gyp

Issue 972383002: snapshot: Add a minimal ModuleSnapshotMinidump and accessor from ProcessSnapshotMinidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Add NOTREACHED() comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/snapshot.gyp

diff --git a/snapshot/snapshot.gyp b/snapshot/snapshot.gyp

index f6e537248b19ef881caccd1d3817bb6ccf1c2d1b..e031760758b5c63f60beeafd85f58065074afcea 100644

--- a/snapshot/snapshot.gyp

+++ b/snapshot/snapshot.gyp

@@ -69,8 +69,12 @@

'mac/thread_snapshot_mac.h',

'minidump/minidump_simple_string_dictionary_reader.cc',

'minidump/minidump_simple_string_dictionary_reader.h',

+ 'minidump/minidump_string_list_reader.cc',

+ 'minidump/minidump_string_list_reader.h',

'minidump/minidump_string_reader.cc',

'minidump/minidump_string_reader.h',

+ 'minidump/module_snapshot_minidump.cc',

+ 'minidump/module_snapshot_minidump.h',

'minidump/process_snapshot_minidump.cc',

'minidump/process_snapshot_minidump.h',

'memory_snapshot.h',

« no previous file with comments | « snapshot/minidump/process_snapshot_minidump_test.cc ('k') | no next file » | no next file with comments »