Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: snapshot/minidump/minidump_simple_string_dictionary_reader.h

Issue 972383002: snapshot: Add a minimal ModuleSnapshotMinidump and accessor from ProcessSnapshotMinidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Add NOTREACHED() comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/mac/process_snapshot_mac.cc ('k') | snapshot/minidump/minidump_simple_string_dictionary_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/minidump/minidump_simple_string_dictionary_reader.h
diff --git a/snapshot/minidump/minidump_simple_string_dictionary_reader.h b/snapshot/minidump/minidump_simple_string_dictionary_reader.h
index 65b7cba8dcadf158ac971f68ea934a5931016222..633ea0f13181578afd6bcc99b0829f502ed24348 100644
--- a/snapshot/minidump/minidump_simple_string_dictionary_reader.h
+++ b/snapshot/minidump/minidump_simple_string_dictionary_reader.h
@@ -30,9 +30,7 @@ namespace internal {
//! location in \a file_reader, and returns it in \a dictionary.
//!
//! \return `true` on success, with \a dictionary set by replacing its contents.
-//! `false` on failure, with a message logged. If any individual strings
-//! cannot be read, or if any duplicate keys are found, it is not considered
-//! an error, although a message will be logged.
+//! `false` on failure, with a message logged.
bool ReadMinidumpSimpleStringDictionary(
FileReaderInterface* file_reader,
const MINIDUMP_LOCATION_DESCRIPTOR& location,
« no previous file with comments | « snapshot/mac/process_snapshot_mac.cc ('k') | snapshot/minidump/minidump_simple_string_dictionary_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698