Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: snapshot/minidump/minidump_string_list_reader.h

Issue 972383002: snapshot: Add a minimal ModuleSnapshotMinidump and accessor from ProcessSnapshotMinidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/minidump/minidump_string_list_reader.h
diff --git a/snapshot/minidump/minidump_simple_string_dictionary_reader.h b/snapshot/minidump/minidump_string_list_reader.h
similarity index 52%
copy from snapshot/minidump/minidump_simple_string_dictionary_reader.h
copy to snapshot/minidump/minidump_string_list_reader.h
index 65b7cba8dcadf158ac971f68ea934a5931016222..1e88a3fd8d3913e5256fa7bdb64227acd6f0f2c5 100644
--- a/snapshot/minidump/minidump_simple_string_dictionary_reader.h
+++ b/snapshot/minidump/minidump_string_list_reader.h
@@ -12,33 +12,33 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#ifndef CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_
-#define CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_
+#ifndef CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_STRING_LIST_READER_H_
+#define CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_STRING_LIST_READER_H_
#include <windows.h>
#include <dbghelp.h>
-#include <map>
#include <string>
+#include <vector>
#include "util/file/file_reader.h"
namespace crashpad {
namespace internal {
-//! \brief Reads a MinidumpSimpleStringDictionary from a minidump file \a
-//! location in \a file_reader, and returns it in \a dictionary.
+//! \brief Reads a list of MinidumpUTF8String objects in a MinidumpRVAList from
+//! a minidump file \a location in \a file_reader, and returns it in \a
+//! list.
//!
-//! \return `true` on success, with \a dictionary set by replacing its contents.
+//! \return `true` on success, with \a list set by replacing its contents.
//! `false` on failure, with a message logged. If any individual strings
-//! cannot be read, or if any duplicate keys are found, it is not considered
-//! an error, although a message will be logged.
-bool ReadMinidumpSimpleStringDictionary(
- FileReaderInterface* file_reader,
- const MINIDUMP_LOCATION_DESCRIPTOR& location,
- std::map<std::string, std::string>* dictionary);
+//! cannot be read, it is not considered an error, although a message will
+//! be logged.
+bool ReadMinidumpStringList(FileReaderInterface* file_reader,
+ const MINIDUMP_LOCATION_DESCRIPTOR& location,
+ std::vector<std::string>* list);
} // namespace internal
} // namespace crashpad
-#endif // CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_
+#endif // CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_STRING_LIST_READER_H_

Powered by Google App Engine
This is Rietveld 408576698