snapshot: Add a minimal ModuleSnapshotMinidump and accessor from ProcessSnapshotMinidump

snapshot/mac/process_snapshot_mac.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 128 matching lines @@
   return exception_.get();
 }
 
 void ProcessSnapshotMac::InitializeThreads() {
   const std::vector<ProcessReader::Thread>& process_reader_threads =
       process_reader_.Threads();
   for (const ProcessReader::Thread& process_reader_thread :
        process_reader_threads) {
     internal::ThreadSnapshotMac* thread = new internal::ThreadSnapshotMac();
     threads_.push_back(thread);
     if (!thread->Initialize(&process_reader_, process_reader_thread)) {

[Robert Sesek, 2015/03/04 01:52:25]

Could you restructure this as:

auto thread = make_scoped_pointer(new internal::ThreadSnapshotMac());
if (thread->Initialize())
  threads_.push_back(thread.release());

?

+      delete thread;
       threads_.pop_back();
     }
   }
 }
 
 void ProcessSnapshotMac::InitializeModules() {
   const std::vector<ProcessReader::Module>& process_reader_modules =
       process_reader_.Modules();
   for (const ProcessReader::Module& process_reader_module :
        process_reader_modules) {
     internal::ModuleSnapshotMac* module = new internal::ModuleSnapshotMac();
     modules_.push_back(module);
     if (!module->Initialize(&process_reader_, process_reader_module)) {
+      delete module;
       modules_.pop_back();
     }
   }
 }
 
 }  // namespace crashpad