Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/guest_view/renderer/iframe_guest_view_request.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: Address comments move destruction callback to GuestViewContainer Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/renderer/iframe_guest_view_request.h
diff --git a/components/guest_view/renderer/iframe_guest_view_request.h b/components/guest_view/renderer/iframe_guest_view_request.h
new file mode 100644
index 0000000000000000000000000000000000000000..aa482ae9dc8f50705d034eb14e2ab793ef50a305
--- /dev/null
+++ b/components/guest_view/renderer/iframe_guest_view_request.h
@@ -0,0 +1,38 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_REQUEST_H_
+#define COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_REQUEST_H_
+
+#include "components/guest_view/renderer/guest_view_request.h"
+#include "ipc/ipc_message.h"
+#include "v8/include/v8.h"
+
+namespace guest_view {
+class GuestViewContainer;
+
+class GuestViewAttachIframeRequest : public guest_view::GuestViewRequest {
Fady Samuel 2015/06/24 22:01:10 nit: Add a description of this class and what it d
lazyboy 2015/06/24 23:01:51 Done.
+ public:
+ GuestViewAttachIframeRequest(GuestViewContainer* container,
+ int render_frame_routing_id,
+ int guest_instance_id,
+ scoped_ptr<base::DictionaryValue> params,
+ v8::Local<v8::Function> callback,
+ v8::Isolate* isolate);
+ ~GuestViewAttachIframeRequest() override;
+
+ void PerformRequest() override;
+ void HandleResponse(const IPC::Message& message) override;
+
+ private:
+ const int render_frame_routing_id_;
+ const int guest_instance_id_;
+ scoped_ptr<base::DictionaryValue> params_;
+
+ DISALLOW_COPY_AND_ASSIGN(GuestViewAttachIframeRequest);
+};
+
+} // namespace guest_view
+
+#endif // COMPONENTS_GUEST_VIEW_RENDERER_IFRAME_GUEST_VIEW_REQUEST_H_

Powered by Google App Engine
This is Rietveld 408576698